Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Wrap reorder projections filter for vector and CUDA images #619

Merged
merged 1 commit into from
Sep 21, 2024
Merged

ENH: Wrap reorder projections filter for vector and CUDA images #619

merged 1 commit into from
Sep 21, 2024

Conversation

arobert01
Copy link
Collaborator

This is needed to reproduce in Python the behavior of the rtkspectralonestep application when subsets are used.

@arobert01 arobert01 force-pushed the spectral branch 2 times, most recently from c672fd5 to 9d00b3f Compare September 19, 2024 14:04
@SimonRit
Copy link
Collaborator

There are a few warnings when loading the new packages:

Template rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,2>,3>,itk::Image<itk::Vector<float,2>,3>>
 already defined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF23IVF23'>
 is redefined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF23IVF23'>
Warning: template already defined 'rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,2>,3>,itk::Image<itk::Vector<float,2>,3>>'
Template rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,3>,3>,itk::Image<itk::Vector<float,3>,3>>
 already defined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF33IVF33'>
 is redefined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF33IVF33'>
Warning: template already defined 'rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,3>,3>,itk::Image<itk::Vector<float,3>,3>>'
Template rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,4>,3>,itk::Image<itk::Vector<float,4>,3>>
 already defined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF43IVF43'>
 is redefined as <class 'itk.rtkReorderProjectionsImageFilterPython.rtkReorderProjectionsImageFilterIVF43IVF43'>
Warning: template already defined 'rtk::ReorderProjectionsImageFilter<itk::Image<itk::Vector<float,4>,3>,itk::Image<itk::Vector<float,4>,3>>'

Can you address them or should I?

@arobert01
Copy link
Collaborator Author

I replaced WRAP_ITK_ALL_TYPES (which already include ITK_VECTOR) by WRAP_ITK_REAL. I hope it will solve the warnings otherwise I'm not sure to be able to fix them.

@SimonRit SimonRit merged commit 85e92df into RTKConsortium:master Sep 21, 2024
40 of 59 checks passed
@SimonRit
Copy link
Collaborator

It seems to have worked, thanks a lot!

@arobert01 arobert01 deleted the spectral branch October 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arobert01 @SimonRit